Update tls_wrap.cc#2486
Closed
JungMinu wants to merge 3 commits intonodejs:masterfrom
JungMinu:patch-1
Closed
Conversation
fix grammatically wrong expression
mscdex
added
tls
silverwind
added
doc
src/tls_wrap.cc
Outdated
Contributor
There was a problem hiding this comment.
this is an improvement but there are still two issues in the comment here (ex 'socket' -> 'the socket', 'callback' -> 'the callback'), would you mind fixing the rest while you're here? :)
fix grammatically wrong expression
Update tls_wrap.cc
Member
Author
|
@brendanashworth Thanks for the comment! |
Member
|
LGTM |
Member
Author
|
@jasnell Thanks! |
Member
|
Can I ask you to please squash the commits down into a single and update the commit log to the pattern shown here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit. Once that's done I'll queue it up to land. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix grammatically wrong expression